python: add combat shim for older distros#3290
Closed
igaw wants to merge 1 commit intolinux-nvme:masterfrom
Closed
python: add combat shim for older distros#3290igaw wants to merge 1 commit intolinux-nvme:masterfrom
igaw wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
Newer SWIG started generating Py_NewRef() calls in its own runtime boilerplate, but Py_NewRef wasn't added until Python 3.10. The mismatch hits any distro with SWIG ≥ 4.1 but Python < 3.10. Suggested-by: Martin Belanger <[email protected]> Signed-off-by: Daniel Wagner <[email protected]>
|
@igaw - Hey Daniel, I've already added this change in a PR I'm working on. I was planning to submit later today. The PR will contain other Python bug-fixes/improvements as per my previous email. |
Collaborator
Author
|
ah okay, just though I do it quickly. I'll pick your version then :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer SWIG started generating Py_NewRef() calls in its own runtime boilerplate, but Py_NewRef wasn't added until Python 3.10. The mismatch hits any distro with SWIG ≥ 4.1 but Python < 3.10.
Suggested-by: Martin Belanger [email protected]